Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the process_kill_on_drop test if bash is not installed. #4079

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Skip the process_kill_on_drop test if bash is not installed. #4079

merged 1 commit into from
Aug 29, 2021

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Aug 28, 2021

Motivation

The process_kill_on_drop test would fail on systems that did not have bash installed.

Solution

Skip that test if the error code indicates that bash cannot be found.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-process Module: tokio/process labels Aug 28, 2021
@Darksonn Darksonn merged commit b67d464 into tokio-rs:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipetkov ipetkov ipetkov approved these changes

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-process Module: tokio/process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asomers @Darksonn @ipetkov