Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec: implement Clone for LengthDelimitedCodec #4089

Merged
merged 1 commit into from
Sep 7, 2021
Merged

codec: implement Clone for LengthDelimitedCodec #4089

merged 1 commit into from
Sep 7, 2021

Conversation

pablosichert
Copy link
Contributor

@pablosichert pablosichert commented Sep 6, 2021 •
edited
Loading

Hey there!

Unless I'm missing a reason why LengthDelimitedCodec can not implement Clone, this would come in handy.

This PR adds Clone to the derive macro, and all the internal fields already implement Clone.

@pablosichert pablosichert mentioned this pull request Sep 6, 2021
Merged
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec labels Sep 7, 2021
@Darksonn Darksonn merged commit 98e78a6 into tokio-rs:master Sep 7, 2021
@pablosichert pablosichert deleted the length-delimited-codec-clone branch September 7, 2021 14:57
@Darksonn Darksonn mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablosichert @Darksonn