Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/io: Add SyncIoBridge #4146

Merged
merged 14 commits into from
Oct 22, 2021
Merged

util/io: Add SyncIoBridge #4146

merged 14 commits into from
Oct 22, 2021

Commits on Oct 5, 2021

  1. util/io: Add SyncIoBridge 

    I'm doing quite a bit of stuff inside `spawn_blocking` because
I need to use some large synchronous APIs.

I found it not entirely obvious how to "bridge" the world of
async I/O with sync I/O.

Since we have a handy "tokio-util" module with an "io" feature,
these small helpers seem like a good fit hopefully!

Extracted these from my code in https://github.com/ostreedev/ostree-rs-ext/blob/main/lib/src/async_util.rs
    @cgwalters
    cgwalters committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    919d827 View commit details
    Browse the repository at this point in the history

  2. fix bounds

    @cgwalters
    cgwalters committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    ca04164 View commit details
    Browse the repository at this point in the history

  3. update docs

    @cgwalters
    cgwalters committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    0b35775 View commit details
    Browse the repository at this point in the history

  4. forward more read methods

    @cgwalters
    cgwalters committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    2d5c9c8 View commit details
    Browse the repository at this point in the history

  5. Mention !Unpin types

    @cgwalters
    cgwalters committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    59a9566 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. If an empty commit is pushed in the git tree, does the CI hear it?

    @cgwalters
    cgwalters committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    e6051a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Update tokio-util/src/io/sync_bridge.rs 

    Co-authored-by: Alice Ryhl <aliceryhl@google.com>
    @cgwalters @Darksonn
    cgwalters and Darksonn authored Oct 8, 2021
    Configuration menu
    Copy the full SHA
    29795db View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Have io depend on tokio/io-util for SyncIoBridge 

    Necessary for the sync bridge work.  I don't know
whether this is OK.
    @cgwalters
    cgwalters committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    541011b View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Remove unncessary build constraint

    @cgwalters
    cgwalters committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    2d8b60c View commit details
    Browse the repository at this point in the history

  2. util: Create a new io-util feature that depends on rt and io 

    Move sync-bridge to it.
    @cgwalters
    cgwalters committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    e7bab76 View commit details
    Browse the repository at this point in the history

  3. util: We only need io-util macro if we have io

    @cgwalters
    cgwalters committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0a91e6d View commit details
    Browse the repository at this point in the history

  4. Update tokio-util/Cargo.toml 

    Co-authored-by: Alice Ryhl <aliceryhl@google.com>
    @cgwalters @Darksonn
    cgwalters and Darksonn authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0584c03 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into sync-io-bridge

    @cgwalters
    cgwalters committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    b8956f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Merge remote-tracking branch 'origin/master' into sync-io-bridge

    @cgwalters
    cgwalters committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    2725071 View commit details
    Browse the repository at this point in the history