chore: bump MSRV to 1.46 #4254
Merged
chore: bump MSRV to 1.46 #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Nov 21, 2021
| @@ -9,6 +9,7 @@ name = "tokio" | |||
| # - Create "v1.0.x" git tag. | |||
| version = "1.14.0" | |||
| edition = "2018" | |||
| rust-version = "1.46" | |||
There was a problem hiding this comment.
According to this page, this emits a warning on versions older than 1.56.
There was a problem hiding this comment.
I don't think this is a problem for the users, because warnings from dependencies will not be displayed. (e.g., syn has been using this field since 1.0.78, but if we build a crate that has syn as a dependency using an older compiler, we will not see the warning.)
There was a problem hiding this comment.
Okay. It seems like we don't get any failures in CI due to this warning either.
Darksonn
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the preparations for #4135. (mio 0.8 requires Rust 1.46)
This also removes dependency on autocfg.
For MSRV policy:
The Rust 1.46 release is over a year old and meets our MSRV policy.
Debian stable's rustc version is 1.48, Ubuntu's rustc version is 1.53, so this meets MSRV policy requested by Make MSRV "whatever popular distros support" AKA "what oldest supported Firefox ESR requires" #3412.