Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
JoinSet
#4335Add
JoinSet
#4335Changes from 1 commit
0caf1e3
8b10985
a3ccb57
c921ea9
f28a0de
ce71797
922d082
d915fcc
650f22c
423929e
5f25059
8bbe89c
b580565
f11a033
ba28c27
2b19d21
bafa50f
238b8c4
3929ab5
a00fc01
2d75745
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like it would also be nice to have APIs to await the completion of all the tasks in the task set. It seems like we might want a method that returns a future that just awaits completion, and maybe also some way to collect all of the future return values. We can think more about that in a future PR, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the details are unclear wrt. returning a
Vec<Result<T, JoinError>>
because it is not#[must_use]
and I'm somewhat tired of seeing people ignoring errors when usingjoin_all
.