Add a has_changed function to watch::Receiver
#4342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm using
sync::watch
to tell a bunch of workers to do some work, and once in a while they check to see what's the latest job, and if there's no new job they should keep doing what they're already doing, and currently the only way to do that is viarex.changed().now_or_never().is_some()
which has someWaker
overhead (see asm in https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=8fdf2f1bf2b6b16827b106dc13ef5895)Solution
Add a
has_changed
method to check if the value had changed.Alternatives
&mut self
function).try_changed
function that doesn't block if the value hasn't changed.