rt: refactor current-thread scheduler #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the name used in the multi-threaded scheduler
carllerche
commented
Jan 5, 2022
Darksonn
added
A-tokio
4 tasks
Darksonn
reviewed
Jan 5, 2022
hawkw
reviewed
Jan 5, 2022
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Darksonn
approved these changes
Jan 6, 2022
taiki-e
added a commit
that referenced
this pull request
Jan 11, 2022
This reverts commit cc8ad36. That commit caused double panic in hyper's test suite.
carllerche
added a commit
that referenced
this pull request
Jan 11, 2022
This reverts commit cc8ad36.
carllerche
added a commit
that referenced
this pull request
Jan 11, 2022
carllerche
added a commit
that referenced
this pull request
Jan 11, 2022
carllerche
added a commit
that referenced
this pull request
Jan 12, 2022
Re-applies #4377 and fixes the bug resulting in Hyper's double panic. Revert: #4394 Original PR: This PR does some refactoring to the current-thread scheduler bringing it closer to the structure of the multi-threaded scheduler. More specifically, the core scheduler data is stored in a Core struct and that struct is passed around as a "token" indicating permission to do work. The Core structure is also stored in the thread-local context. This refactor is intended to support #4373, making it easier to track counters in more locations in the current-thread scheduler. I tried to keep commits small, but the "set Core in thread-local context" is both the biggest commit and the key one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some refactoring to the current-thread scheduler bringing it closer to the structure of the multi-threaded scheduler. More specifically, the core scheduler data is stored in a
Corestruct and that struct is passed around as a "token" indicating permission to do work. TheCorestructure is also stored in the thread-local context.This refactor is intended to support #4373, making it easier to track counters in more locations in the current-thread scheduler.
I tried to keep commits small, but the "set
Corein thread-local context" is both the biggest commit and the key one.