Implement Encoder<BytesMut> for BytesCodec #4465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Let's assume that we want to write an echo server (actually, I'm writing a reverse proxy). It should be great if we can write as following:
However, rustc complains that
Encoder<BytesMut>
is not implemented for BytesCodec. It does not make sense because it implementsEncoder<Bytes>
. Therefore, I added implementation ofEncoder<BytesMut>
for BytesCodec.Solution
Add following implementation: