Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import tracing without the default attributes feature #4592

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Import tracing without the default attributes feature #4592

merged 1 commit into from
Apr 3, 2022

Conversation

paolobarbolini
Copy link
Contributor

Motivation

tracing enables the attributes feature by default, which we don't need here. I'd like to keep a close eye on the proc macro crates in my dependency tree.

Solution

Disable default features and enable only the ones we need.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-tracing Tracing support in Tokio labels Apr 1, 2022
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me. @hawkw any thoughts?

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me!

@Darksonn Darksonn merged commit f8a6cf4 into tokio-rs:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-tracing Tracing support in Tokio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants