Enable ASAN in CI #4696
Merged
Enable ASAN in CI #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finomnis
force-pushed
the
hunting_memory_leaks
branch
from
0d8d724
to
956ca53
Compare
Finomnis
force-pushed
the
hunting_memory_leaks
branch
from
956ca53
to
83a863d
Compare
Finomnis
force-pushed
the
hunting_memory_leaks
branch
from
915a526
to
8443e05
Compare
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LLVM's ASAN is a very useful tool to find memory leaks, and it is built-in for the rust nightly compier.
When I ran it on my local computer, there were several memory leaks detected in the tests.
According to the LLVM docs, ASAN does not produce false positives.
Sadly, ASAN is not yet enabled in the CI.
Solution