Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: various small improvements to LocalKey #4795

Merged
merged 8 commits into from
Jun 30, 2022
Merged

task: various small improvements to LocalKey #4795

merged 8 commits into from
Jun 30, 2022

Conversation

Darksonn
Copy link
Contributor

Fixes the following small issues in LocalKey:

  • Describe all situations in which the methods can panic.
  • Also set the task-local when running the destructor of the future.
  • Don't panic in try_with if the thread-local holding the task-local is destroyed. (as part of shutting down the thread)
  • Improve panic error messages.
  • Implement Debug for TaskLocalFuture.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-task Module: tokio/task labels Jun 29, 2022
@Darksonn @l4l
Add test
cf8633b 
Co-authored-by: Kitsu <mail@kitsu.me>
@Darksonn Darksonn mentioned this pull request Jun 29, 2022
Closed
@Darksonn Darksonn requested a review from LucioFranco June 29, 2022 13:47
LucioFranco
LucioFranco approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't review the drop part super hard since I don't really remember the pin and drop interactions anymore but I assume its fine, the 'static bound should make it all legal anyways iirc from when we designed this.

tokio/src/task/task_local.rs Show resolved Hide resolved
hawkw
hawkw approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a handful of nits, but overall this lgtm!

tokio/src/task/task_local.rs Outdated Show resolved Hide resolved
tokio/src/task/task_local.rs Outdated Show resolved Hide resolved
tokio/src/task/task_local.rs Outdated Show resolved Hide resolved
tokio/src/task/task_local.rs Outdated Show resolved Hide resolved
tokio/src/task/task_local.rs Outdated Show resolved Hide resolved
hawkw
hawkw reviewed Jun 29, 2022
View reviewed changes
tokio/src/task/task_local.rs Outdated Show resolved Hide resolved
@Darksonn Darksonn enabled auto-merge (squash) June 30, 2022 09:23
@Darksonn Darksonn merged commit e6020c0 into master Jun 30, 2022
@Darksonn Darksonn deleted the alice/task-local-improve branch June 30, 2022 10:08
@Darksonn Darksonn mentioned this pull request Jul 12, 2022
Merged
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 18, 2022
Update Rust crate tokio to 1.20.0 (#1458)
1cbccbc 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dependencies | minor | `1.19.2` -> `1.20.0` |
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dev-dependencies | minor | `1.19.2` -> `1.20.0` |

---

### Release Notes

<details>
<summary>tokio-rs/tokio</summary>

### [`v1.20.0`](https://github.com/tokio-rs/tokio/releases/tag/tokio-1.20.0)

[Compare Source](tokio-rs/tokio@tokio-1.19.2...tokio-1.20.0)

##### 1.20.0 (July 12, 2022)

##### Added

-   tokio: add track_caller to public APIs ([#&#8203;4772], [#&#8203;4791], [#&#8203;4793], [#&#8203;4806], [#&#8203;4808])
-   sync: Add `has_changed` method to `watch::Ref` ([#&#8203;4758])

##### Changed

-   time: remove `src/time/driver/wheel/stack.rs` ([#&#8203;4766])
-   rt: clean up arguments passed to basic scheduler ([#&#8203;4767])
-   net: be more specific about winapi features ([#&#8203;4764])
-   tokio: use const initialized thread locals where possible ([#&#8203;4677])
-   task: various small improvements to LocalKey ([#&#8203;4795])

##### Fixed

##### Documented

-   fs: warn about performance pitfall ([#&#8203;4762])
-   chore: fix spelling ([#&#8203;4769])
-   sync: document spurious failures in oneshot ([#&#8203;4777])
-   sync: add warning for watch in non-Send futures ([#&#8203;4741])
-   chore: fix typo ([#&#8203;4798])

##### Unstable

-   joinset: rename `join_one` to `join_next` ([#&#8203;4755])
-   rt: unhandled panic config for current thread rt ([#&#8203;4770])

[#&#8203;4677]: tokio-rs/tokio#4677

[#&#8203;4741]: tokio-rs/tokio#4741

[#&#8203;4755]: tokio-rs/tokio#4755

[#&#8203;4758]: tokio-rs/tokio#4758

[#&#8203;4762]: tokio-rs/tokio#4762

[#&#8203;4764]: tokio-rs/tokio#4764

[#&#8203;4766]: tokio-rs/tokio#4766

[#&#8203;4767]: tokio-rs/tokio#4767

[#&#8203;4769]: tokio-rs/tokio#4769

[#&#8203;4770]: tokio-rs/tokio#4770

[#&#8203;4772]: tokio-rs/tokio#4772

[#&#8203;4777]: tokio-rs/tokio#4777

[#&#8203;4791]: tokio-rs/tokio#4791

[#&#8203;4793]: tokio-rs/tokio#4793

[#&#8203;4795]: tokio-rs/tokio#4795

[#&#8203;4798]: tokio-rs/tokio#4798

[#&#8203;4806]: tokio-rs/tokio#4806

[#&#8203;4808]: tokio-rs/tokio#4808

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjExMS4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1458
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@Noah-Kennedy Noah-Kennedy Noah-Kennedy approved these changes

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darksonn @hawkw @LucioFranco @Noah-Kennedy