Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blanket rename Core to Reactor #56

Merged
merged 8 commits into from
Dec 5, 2017
Merged

Blanket rename Core to Reactor #56

merged 8 commits into from
Dec 5, 2017

Commits on Dec 5, 2017

  1. Remove the Remote type 

    The `Handle` type is now `Send` and `Sync` so the `Remote` type no longer needs
to exist.
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    7c768fc View commit details
    Browse the repository at this point in the history

  2. Remove TcpListener::pending_accept field 

    No need for oneshot shenanigans as now we'll always have the `Handle` available
to us regardless of what thread we're on to associate a new socket
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    329bca1 View commit details
    Browse the repository at this point in the history

  3. Remove NEXT_LOOP_ID 

    This is no longer needed now that the public-facing `CoreId` has been removed
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    259996d View commit details
    Browse the repository at this point in the history

  4. Rename networking constructors with _std 

    This commit renames the various constructors of networking types to have a
`_std` suffix instead of a smorgasboard of other suffixes, canonicalizing on
`_std` as the suffix for constructors which take the libstd corresponding types.
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    8fcce95 View commit details
    Browse the repository at this point in the history

  5. Change need_read and need_write to return an error 

    This commit is targeted at solving tokio-rs/tokio-core#12 and incorporates the
solution from tokio-rs/tokio-core#17. Namely the `need_read` and `need_write`
functions on `PollEvented` now return an error when the connected reactor has
gone away and the task cannot be blocked. This will typically naturally
translate to errors being returned by various connected I/O objects and should
help tear down the world in a clean-ish fashion.
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    e86fc49 View commit details
    Browse the repository at this point in the history

  6. Add TcpListener::accept_std as a method 

    This should allow configuration over what reactor accepted streams go on to by
giving back a libstd-bound object that can then be used later in conjunction
with `TcpStream::from_std`.
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    2e58422 View commit details
    Browse the repository at this point in the history

  7. Tweak the PollEvented::deregister signature 

    This commit changes the `PollEvented::deregister` signature from

    fn deregister(self, handle: &Handle) -> io::Result<()>

to

    fn deregister(&self) -> io::Result<()>

Now that the handles are `Send` and `Sync` there's no longer any need to pass it
in (it's already stored in the `PollEvented` itself). Additionally this switches
to `&self` instead of `self` to allow reclamation of the internal resources if
necessary.
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    4606279 View commit details
    Browse the repository at this point in the history

  8. Blanket rename Core to Reactor 

    This commit uses a script to rename `Core` to `Reactor` all at once, notably:

    find . -name '*.rs' | xargs sed -i 's/\bCore\b/Reactor/g'
    @alexcrichton
    alexcrichton committed Dec 5, 2017
    Configuration menu
    Copy the full SHA
    108e1a2 View commit details
    Browse the repository at this point in the history