-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start adding a global event loop #57
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
use std::io; | ||
use std::thread; | ||
|
||
use reactor::{Reactor, Handle}; | ||
|
||
pub struct HelperThread { | ||
thread: Option<thread::JoinHandle<()>>, | ||
reactor: Handle, | ||
} | ||
|
||
impl HelperThread { | ||
pub fn new() -> io::Result<HelperThread> { | ||
let reactor = Reactor::new()?; | ||
let reactor_handle = reactor.handle().clone(); | ||
let thread = thread::Builder::new().spawn(move || run(reactor))?; | ||
|
||
Ok(HelperThread { | ||
thread: Some(thread), | ||
reactor: reactor_handle, | ||
}) | ||
} | ||
|
||
pub fn handle(&self) -> &Handle { | ||
&self.reactor | ||
} | ||
|
||
pub fn forget(mut self) { | ||
drop(self.thread.take()); | ||
} | ||
} | ||
|
||
impl Drop for HelperThread { | ||
fn drop(&mut self) { | ||
// TODO: kill the reactor thread and wait for it to exit, needs | ||
// `Handle::wakeup` to be implemented in a future PR | ||
} | ||
} | ||
|
||
fn run(mut reactor: Reactor) { | ||
loop { | ||
reactor.turn(None); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
extern crate futures; | ||
extern crate tokio; | ||
|
||
use std::thread; | ||
|
||
use futures::prelude::*; | ||
use tokio::net::{TcpStream, TcpListener}; | ||
use tokio::reactor::Handle; | ||
|
||
macro_rules! t { | ||
($e:expr) => (match $e { | ||
Ok(e) => e, | ||
Err(e) => panic!("{} failed with {:?}", stringify!($e), e), | ||
}) | ||
} | ||
|
||
#[test] | ||
fn hammer() { | ||
let threads = (0..10).map(|_| { | ||
thread::spawn(|| { | ||
let handle = Handle::default(); | ||
let srv = t!(TcpListener::bind(&"127.0.0.1:0".parse().unwrap(), &handle)); | ||
let addr = t!(srv.local_addr()); | ||
let mine = TcpStream::connect(&addr, &handle); | ||
let theirs = srv.incoming().into_future() | ||
.map(|(s, _)| s.unwrap().0) | ||
.map_err(|(s, _)| s); | ||
let (mine, theirs) = t!(mine.join(theirs).wait()); | ||
|
||
assert_eq!(t!(mine.local_addr()), t!(theirs.peer_addr())); | ||
assert_eq!(t!(theirs.local_addr()), t!(mine.peer_addr())); | ||
}) | ||
}).collect::<Vec<_>>(); | ||
for thread in threads { | ||
thread.join().unwrap(); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the default handle point to the global reactor? For new users this might be bit confusing, and for users not using a global event loop this might point to the wrong event loop.
Would
impl Handle { fn global() -> Handle }
(so we can callHandle::global
) be a better approach?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC this was debated at some length on the RFC, but eventually this may not actually return a global handle in the sense that you'll be able to override the return value of
Handle::default
within a particular program scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.