Remove the Reactor::run method
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2017
alexcrichton
force-pushed
the
remove-run
branch
from
40c4918
to
78398e8
Compare
|
I assume that this (and all subsequent) PRs are blocked on #57? |
|
Yes |
|
I didn't see that #57 was updated when I commented. |
This commit removes the `Reactor::run` method which has previously been used to execute futures and turn the reactor at the same time. The tests/examples made heavy usage of this method but they have now all temporarily moved to `wait()` until the futures dependency is upgraded. In the meantime this'll allow us to further trim down the `Reactor` APIs to their final state.
carllerche
force-pushed
the
remove-run
branch
from
78398e8
to
f5e3b9a
Compare
|
I rebased the PR, I will review later. |
carllerche
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
Reactor::runmethod which has previously been used toexecute futures and turn the reactor at the same time. The tests/examples made
heavy usage of this method but they have now all temporarily moved to
wait()until the futures dependency is upgraded. In the meantime this'll allow us to
further trim down the
ReactorAPIs to their final state.This PR is based on #57, only the last commit needs to be reviewed.