Add a check-redox job in GH Action ci.yml workflow #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure where to best add it, and considered in "cross check", but that seems more for CPU architecture than OS. I see some checks appear with the "required" label in the checks list, not sure about that aspect either. |
Darksonn
reviewed
Jun 16, 2023
That's configured in the github admin panel. You can't modify it here. |
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
|
Not sure why the cross-tests remain pending after so long. Any ideas? |
|
It was a problem on my end. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
cargo checkjob for redox-os, to ensure tokio continues to compile correctly for that target, as discussed with @Darksonn in this comment thread #5790 (comment)Motivation
Have tokio support redox-os as a target and avoid changes breaking it.
Solution
Pending solving some issues and providing a CI solution on redox-os to the tokio project, so that build can be done, and tests to run and pass - this interim step add a compile check to ensure that tokio will compile for that target.
Redox-os project will work on build and test run and create new PRs in the future to add them to tokio CI.
Thanks for your collaboration and support of redox-os