Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::error::Error import style fix #5818

Merged
merged 5 commits into from
Jul 3, 2023
Merged

std::error::Error import style fix #5818

merged 5 commits into from
Jul 3, 2023

Conversation

wathenjiang
Copy link
Contributor

std::error::Error import style fix, the same way of use case in https://doc.rust-lang.org/std/error/trait.Error.html

@github-actions github-actions bot added the R-loom Run loom tests on this PR label Jun 26, 2023
@wathenjiang
Copy link
Contributor Author

The tool cargo clippy should warn, but it does not work when I run it in the tokio directory.

Darksonn
Darksonn approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Jul 3, 2023
@Darksonn Darksonn enabled auto-merge (squash) July 3, 2023 07:48
@Darksonn Darksonn removed the R-loom Run loom tests on this PR label Jul 3, 2023
@Darksonn Darksonn merged commit d8847cf into tokio-rs:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wathenjiang @Darksonn