Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: specify the line ending of LinesCodec #5982

Merged
merged 2 commits into from
Sep 8, 2023
Merged

docs: specify the line ending of LinesCodec #5982

merged 2 commits into from
Sep 8, 2023

Conversation

wathenjiang
Copy link
Contributor

@wathenjiang wathenjiang commented Sep 4, 2023 •
edited
Loading

It is to specify the line ending of LinesCodec is \n.

@wathenjiang wathenjiang changed the title docs: specify is the line ending of LinesCodec docs: specify the line ending of LinesCodec Sep 4, 2023
@Darksonn Darksonn added T-docs Topic: documentation A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec labels Sep 4, 2023
@wathenjiang @Darksonn
Update tokio-util/src/codec/lines_codec.rs
7573d52 
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
@wathenjiang
Copy link
Contributor Author

I have changed the code comments above.
CC @Darksonn

Darksonn
Darksonn approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit a6be73e into tokio-rs:master Sep 8, 2023
70 checks passed
@cconstantine cconstantine mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-codec Module: tokio-util/codec T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wathenjiang @Darksonn