sync: add tokio_util::sync::TaskTracker
#6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio-util
Noah-Kennedy
approved these changes
Sep 23, 2023
Darksonn
commented
Sep 23, 2023
This was a hack for something I removed.
Darksonn
commented
Sep 23, 2023
tokio-util/src/sync/task_tracker.rs
Outdated
Comment on lines
280
to
284
| pub fn new() -> Self { | ||
| Self { | ||
| inner: Arc::new(TaskTrackerInner::new()), | ||
| } | ||
| } |
There was a problem hiding this comment.
A thought I had: I could rename this to new_open and add a new_closed. This might help prevent mistakes where you forget to call close.
Darksonn
commented
Sep 23, 2023
hawkw
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
overall, this looks very nice! we've previously written a somewhat similar utility in the drain crate, which essentially provides a combination TaskTracker and CancellationToken, so it's nice to have this as part of tokio-util.
i commented on a few minor nits and suggestions, but overall it looks great!
hawkw
approved these changes
Oct 2, 2023
|
@hawkw Thoughts about the terminology discussed in #6033 (comment)? |
error: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`
60
--> tokio-util/src/task/task_tracker.rs:591:5
61
|
62
591 | fn clone(&self) -> TaskTrackerToken {
63
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
64
|
65
davidbarsky
reviewed
Oct 13, 2023
The page will be updated to use `TaskTracker` after this is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our topic page for graceful shutdown, we currently recommend using the close flag of an mpsc channel to wait for things to shut down. That's pretty terrible. Let's add a dedicated utility for this.
Rendered docs
Closes: #5585