Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update rust-version to 1.63 in all crates #6126

Merged
merged 1 commit into from
Nov 4, 2023
Merged

chore: update rust-version to 1.63 in all crates #6126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tokio-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name = "tokio-macros"
# - Create "tokio-macros-1.x.y" git tag.
version = "2.1.0"
edition = "2021"
rust-version = "1.56"
rust-version = "1.63"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tokio-macros is a dependency of tokio, so I don't think it is a utility crate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll reword the commit message when I merge it. However, I don't see any issue in upgrading it, since the next release of tokio-macros will need at least the next version of Tokio, which is on 1.63.

authors = ["Tokio Contributors <team@tokio.rs>"]
license = "MIT"
repository = "https://github.com/tokio-rs/tokio"
Expand Down
2 changes: 1 addition & 1 deletion tokio-stream/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name = "tokio-stream"
# - Create "tokio-stream-0.1.x" git tag.
version = "0.1.14"
edition = "2021"
rust-version = "1.56"
rust-version = "1.63"
authors = ["Tokio Contributors <team@tokio.rs>"]
license = "MIT"
repository = "https://github.com/tokio-rs/tokio"
Expand Down
2 changes: 1 addition & 1 deletion tokio-test/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name = "tokio-test"
# - Create "tokio-test-0.4.x" git tag.
version = "0.4.3"
edition = "2021"
rust-version = "1.56"
rust-version = "1.63"
authors = ["Tokio Contributors <team@tokio.rs>"]
license = "MIT"
repository = "https://github.com/tokio-rs/tokio"
Expand Down
2 changes: 1 addition & 1 deletion tokio-util/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name = "tokio-util"
# - Create "tokio-util-0.7.x" git tag.
version = "0.7.10"
edition = "2021"
rust-version = "1.56"
rust-version = "1.63"
Copy link

@polarathene polarathene Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, is this no longer accurately representing the minimal version this would compile on? As the issue I raised mentioned it was 1.60 with an older tokio release. (EDIT: I had forgotten about changes to 0.7.10 bumping it again)

I understand with newer tokio releases that 1.56 isn't supported, and the current 1.56 for tokio-util is already inaccurate as a fallback for toolchains below 1.60.

So is rust-version within tokio crates likely not to represent a crates actual minimal toolchain version to compile on? But the MSRV for tokio crates as a whole?

EDIT: My bad, I forgot that a newer release of tokio-util also bumped to hashbrown 0.14 which has rust-version = "1.63" 🤦‍♂️

authors = ["Tokio Contributors <team@tokio.rs>"]
license = "MIT"
repository = "https://github.com/tokio-rs/tokio"
Expand Down
Loading