feature: Allow DST ReadHalf and WriteHalf Type parameters #6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't introduce any way to construct a non-sized |
|
Yeah, that is my oversight. |
C0D3-M4513R
commented
Dec 3, 2023
| /// | ||
| /// To restore this read/write object from its `ReadHalf` and | ||
| /// `WriteHalf` use [`unsplit`](ReadHalf::unsplit()). | ||
| pub struct StreamSpliterHelper<T:?Sized>{ |
There was a problem hiding this comment.
The name of that struct might need improving.
Any suggestions?
|
Seems like there is no good way to create an unsized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to allow wrapping a
AsyncRead+AsyncWritetype with various wrappers, that can modify the stream, whilst still being able to use ReadHalf and WriteHalf. The easiest way to achieve this is by just usingdyn AsyncRead+AsyncWrite.Since ReadHalf and WriteHalf already use an Arc internally, I thought that this might be a good contribution.
Note: this toppic is kind of adjacent to #6169
Solution
I made the
Innerstruct DST, by moving thestreamfield to the end of that struct, because Rust only allows DST's to be at the end of a Struct.Then I modified
ReadHalfandWriteHalfto also allow unsized type Parameters.