task: Add TaskLocalFuture::take_value method to the task_local
#6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mox692
force-pushed
the
task_local_future_take_value
branch
from
10cbb3b
to
61cde0f
Compare
Darksonn
reviewed
Feb 15, 2024
Darksonn
reviewed
Feb 19, 2024
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Try to resolve #5743.
This PR adds a method
take_valueto take the task local value of aTaskLocalFuture.The
LocalKey::scope()function owns the slot value and drops it, but this method will allow you to re-acquire ownership of the slot value.Solution
Implemented method
take_valuefor a pinnedTaskLocalFuture.Maybe it is possible to provide non-pinned api as well (
pub fn take_value(&mut self) -> Option<T>), but I'm not sure if it is worth providing both.