sync: Implement Clone for watch::Sender
#6388
Merged
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mox692
commented
Mar 10, 2024
Darksonn
reviewed
Mar 11, 2024
tokio/src/sync/watch.rs
Outdated
| @@ -146,6 +146,16 @@ pub struct Sender<T> { | |||
| shared: Arc<Shared<T>>, | |||
| } | |||
|
|
|||
| impl<T> Clone for Sender<T> { | |||
| fn clone(&self) -> Self { | |||
| self.shared.ref_count_tx.fetch_add(1, AcqRel); | |||
There was a problem hiding this comment.
When it comes to incrementing refcounts (but not decrementing), relaxed is generally enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR attempt to resolve #4809.
Currently, watch channel has only one sender but this enable it to be mpmc by adding a
cloneof the sender.Solution
As with the reciever, the
ref_count_txfield is added to the shared structure to record the number of senders; this counter is incremented by the sender'sclonemethod and decremented by thedropmethod.