feat: impl Clone for task_local where T: Clone #6433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mox692
reviewed
Mar 27, 2024
|
Maybe we should just expand the |
|
Any updates on this? |
fenollp
force-pushed
the
task-local-clone
branch
from
9785188
to
d01d5c9
Compare
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
fenollp
force-pushed
the
task-local-clone
branch
from
d01d5c9
to
e8a182d
Compare
Darksonn
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
From the docs it is clear one can
LocalKey::get()a copy ofT.I hard a hard time finding how to get a clone of
T(myTis notCopy, it's a struct ofArcs).Solution
This PR adds a
clonemethod alongside the existinggetmethod.