Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix latest rust-1.78.0 warnings #6528

Merged
merged 4 commits into from
May 3, 2024
Merged

chore: fix latest rust-1.78.0 warnings #6528

merged 4 commits into from
May 3, 2024

Conversation

mox692
Copy link
Member

@mox692 mox692 commented May 3, 2024 •
edited
Loading

This PR:

  • fixes warnings introduced in 1.78.0.
    • you can see how it fails, for example, here.
  • changes the target name from wasm32-wasi, wasm32-wasi-preview1-threads to wasm32-wasip1, wasm32-wasip1-threads in ci. (See also Use wasm32-wasip1 target #6484)

@mox692 mox692 added A-ci Area: The continuous integration setup T-wasm Topic: Web Assembly labels May 3, 2024
@github-actions github-actions bot added the R-loom-multi-thread Run loom multi-thread tests on this PR label May 3, 2024
@mox692 mox692 force-pushed the mox692/fix_1-78 branch from e47eb33 to fbab650 Compare May 3, 2024 07:30
Darksonn
Darksonn approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn enabled auto-merge (squash) May 3, 2024 07:44
@mox692
Copy link
Member Author

mox692 commented May 3, 2024

Hmm, it seems that wasm32-wasi workflow, which doesn't exist anymore, is pending forever.

@Darksonn
Copy link
Contributor

Darksonn commented May 3, 2024

It's because it's listed as required in the repository settings. I just removed it from the list of required checks.

@Darksonn Darksonn merged commit 3c8d8e6 into tokio-rs:master May 3, 2024
79 checks passed
@mox692 mox692 deleted the mox692/fix_1-78 branch May 3, 2024 09:40
@brooksmtownsend brooksmtownsend mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-ci Area: The continuous integration setup R-loom-multi-thread Run loom multi-thread tests on this PR T-wasm Topic: Web Assembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mox692 @Darksonn