Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase MSRV to 1.70 #6645

Merged
merged 1 commit into from
Jul 22, 2024
Merged

chore: increase MSRV to 1.70 #6645

merged 1 commit into from
Jul 22, 2024

Conversation

Darksonn
Copy link
Contributor

Mio v1 was recently released, and it requires an MSRV of 1.70.0 for various changes that mio is using to get rid of its SocketAddr type and instead use the std version. This PR proposes to bump the MSRV of Tokio to 1.70.

The main disadvantage is that debian stable is still at rustc 1.63.

Refs: #6635

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Jun 17, 2024
@carllerche
Copy link
Member

Looks like the next debian stable will have 1.75. I don't know when it will be released though.

I'm fine with whatever I guess, but we probably need to keep an LTS that works on debian stable working.

Copy link
Contributor

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would very much help with the update to Mio v1 (#6635).

@Darksonn
Copy link
Contributor Author

@carllerche It looks like it will be ~1 year until debian stable will start using 1.75.0. I don't think we should wait for that. We can make an LTS release now, then bump the MSRV afterwards?

@carllerche
Copy link
Member

I’m fine with it.

@Darksonn Darksonn merged commit 15cd514 into master Jul 22, 2024
79 checks passed
@Darksonn Darksonn deleted the alice/msrv-1.70 branch July 22, 2024 18:01
notmandatory added a commit to bitcoindevkit/bdk that referenced this pull request Jul 27, 2024
28d7530 ci: pin tokio to 1.38.1 to support MSRV 1.63 (Steve Myers)

Pull request description:

  ### Description

  The latest tokio minor version update from 1.38.1 to 1.39.1 changed it's MSRV from 1.63.0 to 1.70.0, breaking our CI MSRV 1.63 testing. This PR pins `tokio` back to 1.38.1 for our CI MSRV testing.

  ### Notes to the reviewers

  tokio-rs/tokio#6645

  https://crates.io/crates/tokio/versions

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  LagginTimes:
    ACK 28d7530
  ValuedMammal:
    ACK 28d7530
  oleonardolima:
    ACK 28d7530

Tree-SHA512: 9eef750422cb8c3faa15771438e790afae44362d7c77e1d36cf70816ac7dabdd2e408e14502836ec86f845a2f1fe82905000c681fb6b4e873b036a41a280abd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants