Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: rename num_active_tasks to num_alive_tasks #6667

Merged
merged 3 commits into from
Jun 30, 2024

Conversation

Darksonn
Copy link
Contributor

The word "active" is the opposite of "idle", but an "idle task" normally refers to a task that is alive but not currently able to make progress. However, idle tasks are included in this counter.

Instead of "active", I propose the name "alive".

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-metrics Module: tokio/runtime/metrics labels Jun 30, 2024
@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Jun 30, 2024
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name change makes sense. It's clearer this way.

@Darksonn Darksonn merged commit 68d0e3c into master Jun 30, 2024
83 checks passed
@Darksonn Darksonn deleted the alice/alive_tasks_count branch June 30, 2024 13:02
This was referenced Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-metrics Module: tokio/runtime/metrics R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants