Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode platform list in short-read optimization #6668

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Hardcode platform list in short-read optimization #6668

merged 2 commits into from
Jul 2, 2024

Conversation

Darksonn
Copy link
Contributor

Closes: #5866

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Jun 30, 2024
@Darksonn Darksonn requested a review from Thomasdezeeuw June 30, 2024 11:39
Thomasdezeeuw
Thomasdezeeuw approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a 100% certain about non-Darwin based kqueue platforms, i.e. the *BSDs, but since it's fairly standard Unix behaviour I assume it works.

@Darksonn
Copy link
Contributor Author

Darksonn commented Jul 2, 2024

We're applying the optimization for those today and nobody has complained, so I will assume it works. If it doesn't, then someone can file a bug.

@Darksonn Darksonn enabled auto-merge (squash) July 2, 2024 20:24
@Darksonn Darksonn merged commit b2e4c5f into master Jul 2, 2024
77 checks passed
@Darksonn Darksonn deleted the alice/platform-hardcode-mio branch July 2, 2024 20:25
This was referenced Jul 22, 2024
Closed
Merged
@rneswold
Copy link

We're applying the optimization for those today and nobody has complained, so I will assume it works. If it doesn't, then someone can file a bug.

I use tokio on NetBSD/aarch64. If this causes a problem, I'll file a report.

@Thomasdezeeuw
Copy link
Contributor

I use tokio on NetBSD/aarch64. If this causes a problem, I'll file a report.

Can you ping me in the issue @rneswold?

@rneswold rneswold mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly fragile coordination between mio and tokio for Windows event-triggered simulation
3 participants
@Darksonn @rneswold @Thomasdezeeuw