Run Quinn tests in CI #6719
Merged
Run Quinn tests in CI #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
quinn-ci
branch
2 times, most recently
from
1edfabd
to
575892c
Compare
|
Not sure how/why warnings are being denied, probably makes sense to allow them for these external crates? |
|
You probably need to override RUST_FLAGS. tokio/.github/workflows/ci.yml Line 14 in f8fe0ff |
|
Any chance you could try pushing a commit that undoes the revert to verify that this would have caught the regression? |
github-actions
bot
added
the
R-loom-time-driver
|
I used and that resulted in failure. So I think this is working as intended, and I'll remove the cherry-picked commit again. |
github-actions
bot
removed
the
R-loom-time-driver
Darksonn
approved these changes
Jul 25, 2024
|
Thanks! |
|
Thank you for all your work on Tokio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve testing for timers (which caused a regression, #6714) by testing Quinn in CI.
Fixes #6717.