Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: fixed yield_now lost wakeup #6999

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

quininer
Copy link
Member

Motivation

Fixes #6996

Solution

The PR makes wake defer only occur in the enter runtime state. this avoid lost wakeup due to defer during exit runtime.

@quininer quininer force-pushed the block-in-place-clear-scheduler branch from 35c4ab9 to c6f9e61 Compare November 29, 2024 15:20
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-task Module: tokio/task M-blocking Module: tokio/task/blocking labels Dec 2, 2024
@Darksonn Darksonn merged commit f8948ea into tokio-rs:master Dec 2, 2024
87 checks passed
@quininer quininer deleted the block-in-place-clear-scheduler branch December 2, 2024 13:54
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Dec 4, 2024
Bumps tokio from 1.41.1 to 1.42.0.

Release notes
Sourced from tokio's releases.

Tokio v1.42.0
1.42.0 (Dec 3rd, 2024)
Added

io: add AsyncFd::{try_io, try_io_mut} (#6967)

Fixed

io: avoid ptr->ref->ptr roundtrip in RegistrationSet (#6929)
runtime: do not defer yield_now inside block_in_place (#6999)

Changes

io: simplify io readiness logic (#6966)

Documented

net: fix docs for tokio::net::unix::{pid_t, gid_t, uid_t} (#6791)
time: fix a typo in Instant docs (#6982)

#6791: tokio-rs/tokio#6791
#6929: tokio-rs/tokio#6929
#6966: tokio-rs/tokio#6966
#6967: tokio-rs/tokio#6967
#6982: tokio-rs/tokio#6982
#6999: tokio-rs/tokio#6999



Commits

bb9d570 chore: prepare Tokio v1.42.0 (#7005)
af9c683 tests: fix typo in build test instructions (#7004)
4bc5a1a ci: allow Unicode-3.0 license for unicode-ident (#7006)
f8948ea runtime: do not defer yield_now inside block_in_place (#6999)
bce9780 time: use array::from_fn instead of manually creating array (#7000)
38151f3 readme: unlist 1.32.x as LTS release (#6997)
5dda72d ci: pin valgrind to rustc 1.82 (#6998)
c07257f io: simplify io readiness logic (#6966)
d08578f time: fix a typo in Instant docs (#6982)
4047d79 miri: add annotations for tests with miri ignore (#6981)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-blocking Module: tokio/task/blocking M-task Module: tokio/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external executor block_on and yield defer do not work together
2 participants