-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: add Command::into_std()
#7014
Conversation
tokio/src/process/mod.rs
Outdated
/// Cheaply convert into a `std::process::Command`. | ||
pub fn into_std(self) -> StdCommand { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want a note to say that Tokio-specific options may not apply to the underlying std command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new version okay?
The spell check failed... The error message appears at |
Method names must be enclosed in backticks. This ensures that the spell checker does not apply to them. -/// Note that Tokio specific options (currently only option [kill_on_drop](Command::kill_on_drop))
+/// Note that Tokio specific options (currently only option [`kill_on_drop`](Command::kill_on_drop)) |
Is it okay now? |
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
All modifications are completed, you can review and see if it can be merged. |
Thank you. |
Fixes: #7001