Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: add Command::into_std() #7014

Merged
merged 5 commits into from
Dec 7, 2024
Merged

Conversation

czy-29
Copy link
Contributor

@czy-29 czy-29 commented Dec 5, 2024

Fixes: #7001

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-process Module: tokio/process labels Dec 5, 2024
@Darksonn Darksonn requested a review from ipetkov December 5, 2024 09:23
Comment on lines 333 to 334
/// Cheaply convert into a `std::process::Command`.
pub fn into_std(self) -> StdCommand {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want a note to say that Tokio-specific options may not apply to the underlying std command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new version okay?

@czy-29
Copy link
Contributor Author

czy-29 commented Dec 5, 2024

The spell check failed... The error message appears at kill_on_drop, but this is a method name... I'm not sure how we should solve this spell check.

@Darksonn
Copy link
Contributor

Darksonn commented Dec 5, 2024

Method names must be enclosed in backticks. This ensures that the spell checker does not apply to them.

-/// Note that Tokio specific options (currently only option [kill_on_drop](Command::kill_on_drop))
+/// Note that Tokio specific options (currently only option [`kill_on_drop`](Command::kill_on_drop))

@czy-29
Copy link
Contributor Author

czy-29 commented Dec 5, 2024

Is it okay now?

tokio/src/process/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
@czy-29
Copy link
Contributor Author

czy-29 commented Dec 7, 2024

All modifications are completed, you can review and see if it can be merged.

@Darksonn Darksonn merged commit dc16b12 into tokio-rs:master Dec 7, 2024
81 checks passed
@Darksonn
Copy link
Contributor

Darksonn commented Dec 7, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-process Module: tokio/process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conversion from tokio::process::Command to std::process::Command
3 participants