Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threadpool: remove smoke example (#764) #770

Merged
merged 2 commits into from
Nov 21, 2018
Merged

threadpool: remove smoke example (#764) #770

merged 2 commits into from
Nov 21, 2018

Conversation

flxo
Copy link
Contributor

@flxo flxo commented Nov 21, 2018

Motivation

The smoke example uses the outdated timer version 0.1 and is considered obsolete by @carllerche.

Solution

Remove smoke.rs and tokio-timer dependency.

resolves #764

carllerche
carllerche approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 👍

@carllerche
Copy link
Member

Looks like Travis is MIA...

@carllerche
Copy link
Member

I pushed an empty commit to restart the build...

@carllerche carllerche merged commit 272e09d into tokio-rs:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tokio-threadpool example to use tokio-timer 0.2
2 participants
@flxo @carllerche