Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tokio-fs
exposes a similar interface asstd::fs
. Some time ago very convenient helpers for reading and writing entire files with a single function call were added to the standard library. The stabilization discussion is available here: rust-lang/rust#46588tokio-fs
don't have these convenient helpers. So just opening a file and reading/writing to it is slightly more cumbersome than it would need to be. I figured that if the community reached consensus on adding these to the standard library, the same arguments would hold fortokio-fs
as well.Solution
Adding two custom futures, that join
File::open
+read_to_end
andFile::create
+write_all
.The read future also polls the fs for metadata and pre-allocates the buffer accordingly. Just like what
std::fs::read
does.