WASI support #147
Merged
WASI support #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was attempting to use this library with a WASI target and it was not compiling. The cfg options in the Cargo.toml and the source files did not match. Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
djc
approved these changes
May 28, 2024
|
Can this target be tested in CI? Would be good to avoid regressions. |
|
@djc we could perhaps add another job to test-build-wasm:
name: build tests (wasm)
needs: check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
target: wasm32-unknown-unknown
- name: build all tests
run: cargo test --no-runI have no familiarity with your CI though so not too sure. |
|
That looks like a good start, could you add that in? |
Signed-off-by: Caleb Schoepp <caleb.schoepp@fermyon.com>
|
Thanks! Going to publish this in #142. |
|
@djc thanks for all the reviews and work on this library 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was attempting to use this library with a WASI target and it was not compiling. The cfg options in the Cargo.toml and the source files did not match. See #146.
Solution
Fix cfg options to match.