Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to opentelemetry 0.25 #164

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Upgrade to opentelemetry 0.25 #164

merged 3 commits into from
Sep 10, 2024

Conversation

ymgyt
Copy link
Contributor

@ymgyt ymgyt commented Sep 10, 2024

Motivation

Update opentelemetry depencencies to 0.25
https://github.com/open-telemetry/opentelemetry-rust/releases/tag/opentelemetry-0.25.0

From version 0.25, OpenTelemetry started using a unified version across all crates.
open-telemetry/opentelemetry-rust#2084

Solution

@@ -702,3 +675,16 @@ where
Ok(())
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand the issue yet, but the test failed because the order of attributes in the exported metrics differed each time. Therefore, I added a sorting process during the assertion.

src/layer.rs Show resolved Hide resolved
src/layer.rs Show resolved Hide resolved
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I think this is mostly looking good, but I'd like to have a cleaner commit history where basically each commit could pass CI (though I won't ask you to actually test this). As such:

  • Please have reorder the commits to put the clippy commit first, as I assume this is independent of the opentelemtry upgrade
  • Please squash the commit with the dependency bump with the commit that fixes the tests, also include the commit for fixing the warnings from deprecations
  • Add a version bump for this crate into the commit that updates the CHANGELOG

@ymgyt
Copy link
Contributor Author

ymgyt commented Sep 10, 2024

Thank you for your review.
I first made a commit addressing Clippy warnings.
I squashed the commits for the OpenTelemetry version bump and deprecation fixes.
I also updated the changelog and bumped the crate version.

@djc djc merged commit 5a3f1fd into tokio-rs:v0.1.x Sep 10, 2024
14 checks passed
@ymgyt ymgyt deleted the otel-0.25 branch September 10, 2024 10:19
@djc
Copy link
Collaborator

djc commented Sep 10, 2024

  • Published tracing-opentelemetry v0.26.0 at registry crates-io
  • [new tag] v0.26.0 -> v0.26.0
  • Release notes

@ymgyt
Copy link
Contributor Author

ymgyt commented Sep 10, 2024

@djc
Sorry for the issue with the CHANGELOG update not being as intended. In the PR, I mistakenly created it as:

[Unreleased]

but it should have been:

0.26.0 (September 10, 2024).

Should I create a PR to address this now?

https://github.com/tokio-rs/tracing-opentelemetry/blob/v0.26.0/CHANGELOG.md

@djc
Copy link
Collaborator

djc commented Sep 10, 2024

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants