Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update opentelemetry to 0.20.0 #36

Merged
merged 7 commits into from
Aug 2, 2023
Merged

update opentelemetry to 0.20.0 #36

merged 7 commits into from
Aug 2, 2023

Conversation

ymgyt
Copy link
Contributor

@ymgyt ymgyt commented Jul 31, 2023

Motivation

Update opentelemetry dependency to use the latest opentelemetry from the tracing ecosystem.

Solution

Modified code affected by opentelemetry changes

@ymgyt ymgyt requested a review from jtescher as a code owner July 31, 2023 00:15
ymgyt
ymgyt commented Jul 31, 2023
View reviewed changes
src/layer.rs Show resolved Hide resolved
ymgyt
ymgyt commented Jul 31, 2023
View reviewed changes
src/lib.rs Show resolved Hide resolved
ymgyt
ymgyt commented Jul 31, 2023
View reviewed changes
src/metrics.rs Show resolved Hide resolved
ymgyt
ymgyt commented Jul 31, 2023
View reviewed changes
src/metrics.rs Show resolved Hide resolved
ymgyt
ymgyt commented Jul 31, 2023
View reviewed changes
tests/metrics_publishing.rs Outdated Show resolved Hide resolved
@emschwartz emschwartz mentioned this pull request Aug 1, 2023
Merged
jtescher
jtescher approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @ymgyt, some small nits that can be done in a follow up if need be

src/lib.rs Show resolved Hide resolved
tests/metrics_publishing.rs Outdated Show resolved Hide resolved
tests/metrics_publishing.rs Show resolved Hide resolved
@ymgyt ymgyt force-pushed the update-opentelemetry branch from 8fc98cc to 6e4752d Compare August 1, 2023 22:23
@ymgyt
Copy link
Contributor Author

ymgyt commented Aug 1, 2023 •
edited
Loading

@jtescher Thanks for the review, I have fixed the indent in comment and added a sum assertion in histogram test.

@ymgyt ymgyt changed the title update opentelemetry to v0.20.0 update opentelemetry to 0.20.0 Aug 2, 2023
@ymgyt
Copy link
Contributor Author

ymgyt commented Aug 2, 2023 •
edited
Loading

CI is failing because of pprof introduced in #27 is failing to build on windows.

https://github.com/tokio-rs/tracing-opentelemetry/actions/runs/5732443857/job/15537409319?pr=36

@jtescher
Copy link
Collaborator

jtescher commented Aug 2, 2023

yeah can fix that in a follow up 👍

@jtescher jtescher merged commit 76771cf into tokio-rs:v0.1.x Aug 2, 2023
@ymgyt ymgyt deleted the update-opentelemetry branch August 2, 2023 01:08
@ymgyt ymgyt mentioned this pull request Aug 2, 2023
Merged
jtescher pushed a commit that referenced this pull request Aug 2, 2023
@ymgyt
chore: use pprof only if target_os is not windows (#40)
d369550 
## Motivation

Fix #39

follow up #36 CI
fail

## Solution

add `#[cfg(not(target_os = "windows"))]` condition to pprof dependencies
@jtescher jtescher mentioned this pull request Aug 2, 2023
Merged
jtescher added a commit that referenced this pull request Aug 4, 2023
@jtescher
Prepare for v0.20.0 release (#41)
d9b18f2 
Changelog:

### Added

- Add `OpenTelemetrySpanExt::set_attribute` function (#34)

### Breaking Changes

- Upgrade to `v0.20.0` of `opentelemetry` (#36)
  For list of breaking changes in OpenTelemetry, see the
[v0.20.0
changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/v0.20.0/opentelemetry-api/CHANGELOG.md#v0200).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymgyt @jtescher