-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #1103 to tracing-subscriber
0.2.x
?
#1271
Comments
thomaseizinger
changed the title
Backport #1103 to
Backport #1103 to Mar 1, 2021
tracing-subscribe
0.2.x
?tracing-subscriber
0.2.x
?
thomaseizinger
added a commit
to comit-network/xmr-btc-swap
that referenced
this issue
Mar 1, 2021
Previously, the time was formatted as ISO8601 timestamps which is barely readable by humans. Activating the `chrono` feature allows us to format with a different format string. The output now looks like this: 2021-03-01 11:59:52 DEBUG Database and seed will be stored in /home/thomas/.local/share/xmr-btc-swap 2021-03-01 11:59:52 DEBUG Starting monero-wallet-rpc on port 40673 2021-03-01 11:59:59 DEBUG Still got 0.00009235 BTC left in wallet, swapping ... 2021-03-01 11:59:59 DEBUG Dialing alice at 12D3KooWCdMKjesXMJz1SiZ7HgotrxuqhQJbP5sgBm2BwP1cqThi 2021-03-01 11:59:59 DEBUG Requesting quote for 0.00008795 BTC There is a double space after the time which is already fixed in tracing-subscriber but not yet released. See tokio-rs/tracing#1271.
thomaseizinger
added a commit
to comit-network/xmr-btc-swap
that referenced
this issue
Mar 1, 2021
Previously, the time was formatted as ISO8601 timestamps which is barely readable by humans. Activating the `chrono` feature allows us to format with a different format string. The output now looks like this: 2021-03-01 11:59:52 DEBUG Database and seed will be stored in /home/thomas/.local/share/xmr-btc-swap 2021-03-01 11:59:52 DEBUG Starting monero-wallet-rpc on port 40673 2021-03-01 11:59:59 DEBUG Still got 0.00009235 BTC left in wallet, swapping ... 2021-03-01 11:59:59 DEBUG Dialing alice at 12D3KooWCdMKjesXMJz1SiZ7HgotrxuqhQJbP5sgBm2BwP1cqThi 2021-03-01 11:59:59 DEBUG Requesting quote for 0.00008795 BTC There is a double space after the time which is already fixed in tracing-subscriber but not yet released. See tokio-rs/tracing#1271.
thomaseizinger
added a commit
to comit-network/xmr-btc-swap
that referenced
this issue
Mar 1, 2021
Previously, the time was formatted as ISO8601 timestamps which is barely readable by humans. Activating the `chrono` feature allows us to format with a different format string. The output now looks like this: 2021-03-01 11:59:52 DEBUG Database and seed will be stored in /home/thomas/.local/share/xmr-btc-swap 2021-03-01 11:59:52 DEBUG Starting monero-wallet-rpc on port 40673 2021-03-01 11:59:59 DEBUG Still got 0.00009235 BTC left in wallet, swapping ... 2021-03-01 11:59:59 DEBUG Dialing alice at 12D3KooWCdMKjesXMJz1SiZ7HgotrxuqhQJbP5sgBm2BwP1cqThi 2021-03-01 11:59:59 DEBUG Requesting quote for 0.00008795 BTC There is a double space after the time which is already fixed in tracing-subscriber but not yet released. See tokio-rs/tracing#1271.
thomaseizinger
added a commit
to comit-network/xmr-btc-swap
that referenced
this issue
Mar 1, 2021
Previously, the time was formatted as ISO8601 timestamps which is barely readable by humans. Activating the `chrono` feature allows us to format with a different format string. The output now looks like this: 2021-03-01 11:59:52 DEBUG Database and seed will be stored in /home/thomas/.local/share/xmr-btc-swap 2021-03-01 11:59:52 DEBUG Starting monero-wallet-rpc on port 40673 2021-03-01 11:59:59 DEBUG Still got 0.00009235 BTC left in wallet, swapping ... 2021-03-01 11:59:59 DEBUG Dialing alice at 12D3KooWCdMKjesXMJz1SiZ7HgotrxuqhQJbP5sgBm2BwP1cqThi 2021-03-01 11:59:59 DEBUG Requesting quote for 0.00008795 BTC There is a double space after the time which is already fixed in tracing-subscriber but not yet released. See tokio-rs/tracing#1271.
thomaseizinger
added a commit
to comit-network/xmr-btc-swap
that referenced
this issue
Mar 2, 2021
Previously, the time was formatted as ISO8601 timestamps which is barely readable by humans. Activating the `chrono` feature allows us to format with a different format string. The output now looks like this: 2021-03-01 11:59:52 DEBUG Database and seed will be stored in /home/thomas/.local/share/xmr-btc-swap 2021-03-01 11:59:52 DEBUG Starting monero-wallet-rpc on port 40673 2021-03-01 11:59:59 DEBUG Still got 0.00009235 BTC left in wallet, swapping ... 2021-03-01 11:59:59 DEBUG Dialing alice at 12D3KooWCdMKjesXMJz1SiZ7HgotrxuqhQJbP5sgBm2BwP1cqThi 2021-03-01 11:59:59 DEBUG Requesting quote for 0.00008795 BTC There is a double space after the time which is already fixed in tracing-subscriber but not yet released. See tokio-rs/tracing#1271.
Whoops, I thought this one had already been backported. I'll take care of it --- thanks for letting us know! |
abraham-nixon
added a commit
to abraham-nixon/xmr-btc-swap
that referenced
this issue
Feb 15, 2022
Previously, the time was formatted as ISO8601 timestamps which is barely readable by humans. Activating the `chrono` feature allows us to format with a different format string. The output now looks like this: 2021-03-01 11:59:52 DEBUG Database and seed will be stored in /home/thomas/.local/share/xmr-btc-swap 2021-03-01 11:59:52 DEBUG Starting monero-wallet-rpc on port 40673 2021-03-01 11:59:59 DEBUG Still got 0.00009235 BTC left in wallet, swapping ... 2021-03-01 11:59:59 DEBUG Dialing alice at 12D3KooWCdMKjesXMJz1SiZ7HgotrxuqhQJbP5sgBm2BwP1cqThi 2021-03-01 11:59:59 DEBUG Requesting quote for 0.00008795 BTC There is a double space after the time which is already fixed in tracing-subscriber but not yet released. See tokio-rs/tracing#1271.
Realized that we can close this issue now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there!
Was about to open a PR that fixes the trailing space in the
ChronoLocal
time formatter only to see that it is already fixed in master! :)Is there a chance we can get #1103 backported to a
0.2.x
release oftracing-subscriber
?Thank you!
The text was updated successfully, but these errors were encountered: