-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: log feature breaks existing event macro usages #196
Labels
Comments
hawkw
added
crate/tracing
Related to the `tracing` crate
kind/bug
Something isn't working
labels
Jul 18, 2019
Skepfyr
added a commit
to Skepfyr/tracing
that referenced
this issue
Jan 9, 2022
This cheanges the event macro (and all the upstream macros like info!), so that it only uses each field once when the log feature is enabled. Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. This change generates the log using the `ValueSet` meaning the token trees are only substituted once. Fixes: tokio-rs#196, tokio-rs#1739
Skepfyr
added a commit
to Skepfyr/tracing
that referenced
this issue
Jan 9, 2022
This changes the event macro (and all the upstream macros like info!), so that it only uses each field once when the log feature is enabled. Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. This change generates the log using the `ValueSet` meaning the token trees are only substituted once. Fixes: tokio-rs#196, tokio-rs#1739
hawkw
pushed a commit
that referenced
this issue
Jan 29, 2022
## Motivation Fixes: #196, #1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
hawkw
pushed a commit
that referenced
this issue
Feb 3, 2022
## Motivation Fixes: #196, #1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
hawkw
pushed a commit
that referenced
this issue
Feb 3, 2022
## Motivation Fixes: #196, #1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
hawkw
pushed a commit
that referenced
this issue
Feb 3, 2022
## Motivation Fixes: #196, #1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
hawkw
pushed a commit
that referenced
this issue
Feb 3, 2022
## Motivation Fixes: #196, #1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
hawkw
pushed a commit
that referenced
this issue
Feb 4, 2022
## Motivation Fixes: #196, #1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this issue
May 22, 2024
## Motivation Fixes: tokio-rs#196, tokio-rs#1739 Previously, the `field` token trees would be substituted into the log macro invocation and the `ValueSet`, potentially meaning they are executed more than once. ## Solution This changes the `event!` macro (and all the upstream macros like `info!`), so that it only uses each field once when the log feature is enabled. It does this by generating the log using the `ValueSet` meaning the token trees are only substituted once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: