Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriber: don't escape field values in JSON #391

Closed
hawkw opened this issue Oct 18, 2019 · 1 comment · Fixed by #420
Closed

subscriber: don't escape field values in JSON #391

hawkw opened this issue Oct 18, 2019 · 1 comment · Fixed by #420
Labels
crate/fmt Related to the `tracing-fmt` crate crate/subscriber Related to the `tracing-subscriber` crate

Comments

@hawkw
Copy link
Member

hawkw commented Oct 18, 2019

Feature Request

Crates

  • tracing-subscriber

Motivation

Follow-up from #377. Currently, field values of spans in tracing-subscriber::fmt JSON output are escaped strings. This should be fixed (see #377 (comment)).
@hawkw hawkw added crate/fmt Related to the `tracing-fmt` crate crate/subscriber Related to the `tracing-subscriber` crate labels Oct 18, 2019
@davidbarsky
Copy link
Member

This is fixed in 9dc5402.

@hawkw hawkw mentioned this issue Nov 12, 2019
Merged
davidbarsky added a commit that referenced this issue Nov 14, 2019
@davidbarsky
subscriber: Introduce Registry; Refactor fmt::Subscriber in terms of …
919a628 
…Registry + Layers (#420)

This branch introduces: 

- A registry build atop of https://github.com/hawkw/sharded-slab. Layers
  are expected to consume this registry through the traits `SpanData`,
  `LookupSpan`, and `LookupMetadata`. Layer-specific data, such as
  formatted spans and events, are stored in the `Extensions` typemap. Data
  is writable via the `ExtensionsMut` view struct of the typemap. This
  enables layers to read and write data that they are specifically
  interested in.

- The `tracing_subscriber::fmt::Subscriber` has been re-implemented in
  terms of `tracing_subscriber::registry::Registry` and
  `tracing_subscriber::fmt::Layer`.

- The event/field formatters have been modified (in a non-backwards
  compatible way) to accept a `tracing_subscriber::fmt::FmtContext`. A
  similar structure existed in `tracing_subscriber::fmt::Subscriber`, but
  it was not publicly exposed.

Resolves #135 Resolves #157 Resolves #391

Signed-off-by: David Barsky <me@davidbarsky.com>
Coauthored-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate/fmt Related to the `tracing-fmt` crate crate/subscriber Related to the `tracing-subscriber` crate
Projects
None yet
Milestone
No milestone
2 participants
@davidbarsky @hawkw