-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Debug Netlify Build #1130
Conversation
Hi! We use a bunch of Rust at Netlify and I started using it to publish docs for private crates since we introduced support for If you have a |
That's rad!
I know it's a bit late for you, but I've written a more extensive writeup of what I think happened here: netlify/build-image#505. I'd be happy to move the discussion wherever.
That's a pretty handy feature! Unfortunately, I don't think a |
i opened a PR here that should work: #1131 |
## Motivation At Netlify we recently introduced native Rust support in the build system: netlify/build-image#477 ## Solution This PR cleans up the Netlify build config to use a more straight-forward way of building rust docs. This also introduces a workaround for netlify/build-image#505 ## Kudos We're big fans of the `tracing` crate at Netlify and using it for many new systems recently. Very happy we can give something back! Closes #1130
## Motivation At Netlify we recently introduced native Rust support in the build system: netlify/build-image#477 ## Solution This PR cleans up the Netlify build config to use a more straight-forward way of building rust docs. This also introduces a workaround for netlify/build-image#505 ## Kudos We're big fans of the `tracing` crate at Netlify and using it for many new systems recently. Very happy we can give something back! Closes #1130
It seems like netlify/build-image#477 might have broken our documentation previews, but in fairness to Netlify, I think we were the only ones who were doing a "render and deploy cargo doc" for each PR. Here's what I think is happening with netlify/build-image#477:
cache_cwd_directory
function (callsite, definition) moves Cargo's build output to$NETLIFY_CACHE_DIR
.cache_cwd_directory
callsmove_cache
, which removes the Cargo-generatedtarget
directory. This explains why we see errors from Netlify that informing us that "target/doc does not exist".To get around this, I've tried to change the output directory to not be
target
, but that's not sufficient.