Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: take valuable Values by value #1888

Merged
merged 1 commit into from
Feb 2, 2022
Merged

core: take valuable Values by value #1888

merged 1 commit into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. core: take valuable Values by value

    In #1881, I accidentally had the `Visit` trait take a `&Value<'_>`. This
    was probably wrong, since `Value` is `Copy` and should only be a couple
    words, one of which might be a pointer...so it's probably better to just
    pass the `pointer + enum descriminant` (or `integer + enum descriminant`)
    instead of passing `pointer to (pointer + enum descriminant)`.
    
    This probably also makes the API a little nicer.
    hawkw committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    872d205 View commit details
    Browse the repository at this point in the history