Fixed typo in tracing-appender README #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Feb 21, 2022
hawkw
pushed a commit
that referenced
this pull request
Feb 28, 2022
## Motivation Found a typo as code didn't work as is. ## Solution Fixed the typo :)
hawkw
added a commit
that referenced
this pull request
Feb 28, 2022
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851]) - `parking_lot`: updated to v0.12 ([#1878]) ### Fixed - Fixed several documentation typos and issues ([#1780], [d868054], [#1943]) [#1760]: #1760 [#1851]: #1851 [#1878]: #1878 [#1943]: #1943 [d868054]: d868054
hawkw
added a commit
that referenced
this pull request
Feb 28, 2022
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851]) - `parking_lot`: updated to v0.12 ([#1878]) ### Fixed - Fixed several documentation typos and issues ([#1780], [d868054], [#1943]) [#1760]: #1760 [#1851]: #1851 [#1878]: #1878 [#1943]: #1943 [d868054]: d868054
hawkw
added a commit
that referenced
this pull request
Feb 28, 2022
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851]) - `parking_lot`: updated to v0.12 ([#1878]) ### Fixed - Fixed several documentation typos and issues ([#1780], [d868054], [#1943]) [#1760]: #1760 [#1851]: #1851 [#1878]: #1878 [#1943]: #1943 [d868054]: d868054
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([tokio-rs#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([tokio-rs#1851]) - `parking_lot`: updated to v0.12 ([tokio-rs#1878]) ### Fixed - Fixed several documentation typos and issues ([tokio-rs#1780], [d868054], [tokio-rs#1943]) [tokio-rs#1760]: tokio-rs#1760 [tokio-rs#1851]: tokio-rs#1851 [tokio-rs#1878]: tokio-rs#1878 [tokio-rs#1943]: tokio-rs#1943 [d868054]: tokio-rs@d868054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Found a typo as code didn't work as is.
Solution
Fixed the typo :)