Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ?i requires unicode-case feature in regex crate #2567

Closed
wants to merge 1 commit into from

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Apr 21, 2023

Use of tracing-subscriber where the required regex feature happens to not be activated will otherwise panic: https://github.com/rune-rs/rune/actions/runs/4764385803/jobs/8468908332

An alternative might be to switch to unicode-unaware matching, but I haven't had enough coffee in me today to decide whether that will cause some other issue.

I'm not entirely sure this is enough, but I sure hope so!

@udoprog udoprog added the kind/bug Something isn't working label Apr 21, 2023
@udoprog udoprog requested review from hawkw, davidbarsky and a team as code owners April 21, 2023 11:47
@dbidwell94
Copy link
Contributor

This PR is a duplicate of #2566

@udoprog
Copy link
Contributor Author

udoprog commented Apr 21, 2023

Sure is!

@udoprog udoprog closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants