bug(tracing): register_callsite doesn't get called
#2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
force-pushed
the
hds/missed-register-callsite
branch
from
f0eb1b6
to
df3e1bf
Compare
This branch contains code to reproduce an issue where 2 thread local subscribers interfer so that when the first one takes too long to complete `register_callsite()`, the second subscriber doesn't have `register_callsite()` called at all. It also contains an attempt at a fix by removing a race condition in `DefaultCallsite::register`. This fix may be necessary anyway, but it isn't sufficient. The issue for this problem is #2743.
hds
force-pushed
the
hds/missed-register-callsite
branch
from
df3e1bf
to
5f7c1b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - JUST A REPRO
This branch contains code to reproduce an issue where 2 thread local
subscribers interfer so that when the first one takes too long to
complete
register_callsite(), the second subscriber doesn't haveregister_callsite()called at all.It also contains an attempt at a fix by removing a race condition in
DefaultCallsite::register. This fix may be necessary anyway, but itisn't sufficient.
The issue for this problem is #2743.