tracing: fix record_all panic #3432
Merged
+364
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
force-pushed
the
fix-record-all-panic
branch
from
2676a31 to
cf67fdb
Compare
conradludgate
force-pushed
the
fix-record-all-panic
branch
from
cf67fdb to
fe8b887
Compare
conradludgate
commented
Nov 28, 2025
hds
added
kind/bug
hds
requested changes
Dec 1, 2025
Contributor
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Thanks for this PR!
I think it would be good to have a little more test coverage. Especially because these macros are frequent sources of unintentional breaking changes.
conradludgate
force-pushed
the
fix-record-all-panic
branch
from
609f97c to
650894d
Compare
hds
approved these changes
Dec 11, 2025
Contributor
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Great! Thank you for this fix!
hds
added a commit
that referenced
this pull request
Dec 17, 2025
hds
added a commit
that referenced
this pull request
Dec 18, 2025
hds
added a commit
that referenced
this pull request
Dec 18, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3431
Solution
This is horrible. We rename
valueset!tovalueset_all!, then we re-introduce the originalvalueset!with some notable changes.The new
valueset!doesn't use fields from the fieldset iterator, it instead usesFieldSet::field(...)to find the correct field. If the field isn't found, we set a fallback field that will be ignored (callsites are not equal).