fmt: Support disabling the target in formatted output #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Thanks, this looks good to me.
It looks like the CI failure is due to RustDoc link resolution issues, these don't seem to be in the code added in this PR. Since we build docs against nightly Rust, my guess is that something changed on nightly (possibly a regression?) and broke the RustDoc. I'll try to finish that separately, since it's not caused by these changes, and I'll merge this once CI is green.
Thanks again for your contribution!
|
Okay, fixed the docs build error. I'm going to go ahead and merge this now. Thanks again! |
LucioFranco
added a commit
that referenced
this pull request
Feb 27, 2020
Signed-off-by: Lucio Franco <luciofranco14@gmail.com>
hawkw
pushed a commit
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for disabling level in formatted output.
Fixes: #592