attributes: check if a skipped parameter exists #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the CI failure is because rustfmt needs to be run? |
hawkw
approved these changes
Feb 24, 2020
hawkw
added a commit
that referenced
this pull request
Feb 26, 2020
Added: - Support for adding arbitrary literal fields to spans generated by `#[instrument]` (#569) - `#[instrument]` now emits a helpful compiler error when attempting to skip a function parameter (#600) Thanks to @Kobzol for contributing to this release! Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Feb 26, 2020
### Added - Support for adding arbitrary literal fields to spans generated by `#[instrument]` (#569) - `#[instrument]` now emits a helpful compiler error when attempting to skip a function parameter (#600) Thanks to @Kobzol for contributing to this release! Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Feb 26, 2020
Added: - **field**: `field::Empty` type for declaring empty fields whose values will be recorded later (#548) - **field**: `field::Value` implementations for `Wrapping` and `NonZero*` numbers (#538) - **attributes**: Support for adding arbitrary literal fields to spans generated by `#[instrument]` (#569) - **attributes**: `#[instrument]` now emits a helpful compiler error when attempting to skip a function parameter (#600) Changed: - **attributes**: The `#[instrument]` attribute was placed under an on-by-default feature flag "attributes" (#603) Fixed: - Broken and unresolvable links in RustDoc (#595) Thanks to @oli-cosmian and @Kobzol for contributing to this release! Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Feb 27, 2020
### Added - **field**: `field::Empty` type for declaring empty fields whose values will be recorded later (#548) - **field**: `field::Value` implementations for `Wrapping` and `NonZero*` numbers (#538) - **attributes**: Support for adding arbitrary literal fields to spans generated by `#[instrument]` (#569) - **attributes**: `#[instrument]` now emits a helpful compiler error when attempting to skip a function parameter (#600) ### Changed - **attributes**: The `#[instrument]` attribute was placed under an on-by-default feature flag "attributes" (#603) ### Fixed - Broken and unresolvable links in RustDoc (#595) Thanks to @oli-cosmian and @Kobzol for contributing to this release! Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the
#[instrument]macro to emit a compiler error if the user tries to skip non-existing parameters.Fixes: #562