Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a non blocking file appender #673

Merged
merged 46 commits into from
Apr 14, 2020
Merged

Introduce a non blocking file appender #673

merged 46 commits into from
Apr 14, 2020

Commits on Apr 8, 2020

  1. Introduce a non blocking file appender

    Zeki Sherif committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    945f4a8 View commit details
    Browse the repository at this point in the history

  2. Use public interface for Rotation enum 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    9ccaa5d View commit details
    Browse the repository at this point in the history

  3. simply if statement 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    2a34863 View commit details
    Browse the repository at this point in the history

  4. Make WriterFactory pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    39f2709 View commit details
    Browse the repository at this point in the history

  5. Make BufWriterFactory pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f251bbe View commit details
    Browse the repository at this point in the history

  6. Make InnerAppender pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    de77617 View commit details
    Browse the repository at this point in the history

  7. Make InnerAppender constructor pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    7c9ce25 View commit details
    Browse the repository at this point in the history

  8. make refresh_writer pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    e028dfa View commit details
    Browse the repository at this point in the history

  9. Make should_rollover pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    55bdffe View commit details
    Browse the repository at this point in the history

  10. Make WorkerState pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    1a70543 View commit details
    Browse the repository at this point in the history

  11. Make Worker pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    5b4eacf View commit details
    Browse the repository at this point in the history

  12. make constructor pub(crate) 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    18d0340 View commit details
    Browse the repository at this point in the history

  13. Apply suggested readability improvements and using pub(crate) where a… 

    …ppropriate

Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    c4a8447 View commit details
    Browse the repository at this point in the history

  14. Use new Rotation const in match expressions. derive Copy trait for Ro… 

    …tation
    Zeki Sherif committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    1c33af9 View commit details
    Browse the repository at this point in the history

  15. Remove copy trait from Rotation.

    Zeki Sherif committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    6e8cb23 View commit details
    Browse the repository at this point in the history

  16. Use Path for log_directory and filename prefix 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    75ee728 View commit details
    Browse the repository at this point in the history

  17. Properly handle use of Path in non public facing apis

    Zeki Sherif committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    e5944c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Use Arc for error_counter, modify fileappender constructor

    Zeki Sherif committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    cc4fde7 View commit details
    Browse the repository at this point in the history

  2. Fix getters for FileAppender, clone writer for getter

    Zeki Sherif committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    d9968b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. WIP: Decoupling file appender and nonblocking

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    a1f0d01 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 10, 2020
    Configuration menu
    Copy the full SHA
    9316656 View commit details
    Browse the repository at this point in the history

  3. Update Rotation helpers and add constructor

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    ac14ca3 View commit details
    Browse the repository at this point in the history

  4. Remove generic from InnerAppender, use BufWriter always

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    b3aadef View commit details
    Browse the repository at this point in the history

  5. Move creation of log file to Inner. Get rid of BufWriterFactory

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f77a6a8 View commit details
    Browse the repository at this point in the history

  6. Remove multiple impl of InnerAppender

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4417342 View commit details
    Browse the repository at this point in the history

  7. Impl MakeWriter on NonBlocking and remove NonBlockingWriter

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    64b356f View commit details
    Browse the repository at this point in the history

  8. Override write_all 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 10, 2020
    Configuration menu
    Copy the full SHA
    98db6f7 View commit details
    Browse the repository at this point in the history

  9. Use T:Write, get rid of RollingFileWriter

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    ec049e0 View commit details
    Browse the repository at this point in the history

  10. cargo fmt

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    be7aeb4 View commit details
    Browse the repository at this point in the history

  11. Add lossy option for non_blocking

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    e87b631 View commit details
    Browse the repository at this point in the history

  12. Add WorkerGuard and ensure closure of worker thread on drop

    Zeki Sherif committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    5d8475c View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    2983370 View commit details
    Browse the repository at this point in the history

  2. address comments

    Zeki Sherif committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    8e6a395 View commit details
    Browse the repository at this point in the history

  3. Add comment about worker thread yielding

    Zeki Sherif committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    80bf8e2 View commit details
    Browse the repository at this point in the history

  4. Fix clippy warnings

    Zeki Sherif committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    8f9bdc1 View commit details
    Browse the repository at this point in the history

  5. Fix 1 more clippy warning

    Zeki Sherif committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    e467bdd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Add 2 examples

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    4b73a1c View commit details
    Browse the repository at this point in the history

  2. Take suggestions for example doc improvements

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    2b6cb51 View commit details
    Browse the repository at this point in the history

  3. fix clippy warning about needless main

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    9e7620d View commit details
    Browse the repository at this point in the history

  4. Revert "fix clippy warning about needless main" 

    This reverts commit 9e7620d.
    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    b415265 View commit details
    Browse the repository at this point in the history

  5. Add tracing dev dependency, fix clippy warning

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    4ed792c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 14, 2020
    Configuration menu
    Copy the full SHA
    93b26af View commit details
    Browse the repository at this point in the history

  7. Supress clippy warning using attribute

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    f494d53 View commit details
    Browse the repository at this point in the history

  8. Fix fmt

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    5216e6c View commit details
    Browse the repository at this point in the history

  9. Update tracing-appender/src/rolling.rs 

    Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
    @zekisherif @hawkw
    zekisherif and hawkw authored Apr 14, 2020
    Configuration menu
    Copy the full SHA
    97e5e15 View commit details
    Browse the repository at this point in the history

  10. fix doc

    Zeki Sherif committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    714e5bd View commit details
    Browse the repository at this point in the history