feat: sso implementation #2523

huglx · 2024-10-06T13:15:54Z

What I have done:

adding SSO providers
logging via SSO
New users now become a member of the organization that issued the SSO provider
customized login page for self-hosted instances
started writing tests

What I plan to add:

collect the user's role that the organization set for them and grant these roles to the user
more test coverage
simplify adding a provider (there is a URL that calls .../well-known/openid-configuration, and through this URL, I can fetch all needed URLs)

tbc

…n a JWT token for login.

… integrity exception.

…n that issued the sso provider

Anty0

There are also a lot of unrelated formatting changes as part of the PR. They seem irrelevant to the PR, and I'd rather see them reverted.

backend/data/src/main/kotlin/io/tolgee/model/UserAccount.kt

backend/data/src/main/kotlin/io/tolgee/repository/UserAccountRepository.kt

backend/data/src/main/kotlin/io/tolgee/service/organization/OrganizationRoleService.kt

backend/data/src/main/kotlin/io/tolgee/service/organization/OrganizationService.kt

backend/data/src/main/kotlin/io/tolgee/service/security/SignUpService.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/data/SsoTenantDto.kt

backend/data/src/main/kotlin/io/tolgee/configuration/tolgee/AuthenticationProperties.kt

backend/api/src/main/kotlin/io/tolgee/configuration/PublicConfigurationDTO.kt

backend/api/src/main/kotlin/io/tolgee/hateoas/ee/SsoTenantModel.kt

backend/data/src/main/kotlin/io/tolgee/configuration/tolgee/AuthenticationProperties.kt

Anty0

I'll merge the changes to the sso branch to start writing code on top of them, but all open review notes still apply—please check and fix them. Notably, there are still many formatting changes throughout the patch set.

backend/data/src/main/kotlin/io/tolgee/model/UserAccount.kt

...d/data/src/main/kotlin/io/tolgee/component/cacheWithExpiration/CacheWithExpirationManager.kt

backend/data/src/main/kotlin/io/tolgee/model/UserAccount.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/model/SsoTenant.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/api/v2/controllers/OAuth2CallbackController.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/service/OAuthService.kt

backend/api/src/main/kotlin/io/tolgee/configuration/PublicConfigurationDTO.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/service/TenantService.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/service/OAuthService.kt

huglx added 30 commits September 2, 2024 15:06

feat: create dynamic client registration

a52e18e

feat: Add a tenant to configure the dynamic configuration of providers.

278aa62

feat: Add a controller to fetch callbacks from the provider and retur…

140c6df

…n a JWT token for login.

feat: Add a controller to dynamically configure providers

b5e75b9

feat: add sso login to FE

f7b8c0a

fix: move auth logic from controller to service

4a14242

feat: add custom exceptions

8302d33

fix: add component annotation

10a70b7

feat: save domain with port if presents

ac291db

fix: change url

1143485

fix: add more properties CreateProviderRequest

d8dfdb8

fix: The function wasn't marked as a transaction, so it caused a data…

e6a8cd3

… integrity exception.

feat: add an ability to accept invitation code to backend part

fccbe74

feat: add properties to enable custom logo & button text

de3cd3c

feat: add create sso provider route

8d285fa

feat: add an ability to set custom login logo to FE

e866ebb

feat: add create sso provider links

10f4022

feat: pass invitationCode to BE

c468f2c

feat: display saved provider on FE

bf60293

feat: verify id token to improve security

b7297a0

feat: disable/enable sso provider FE

45acdfe

feat: also set jwk uri in ClientRegistration

f1e4999

feat: now a new user logged in via sso is a member of the organizatio…

0477f25

…n that issued the sso provider

feat: refactor login form FE

8a83e52

feat: enable/disable provider

0cc553d

feat: add function to add user to the org.

d21a845

feat: throw if sso provider is disabled

c906b4e

fix: code clean up

40e444d

chore: test

e494b5c

feat: configuration to parse jwt token

fdfa217

huglx added 11 commits October 21, 2024 19:30

fix: add sso feature message

a3d655e

fix: renaming

0672f26

fix: prettier

72b531e

fix: prettier

f232ae6

fix: remove scope

61e5fd3

feat: prevent sso user from create organizations

ac207b6

fix: if it's sso user find by sso domain

53df0c0

fix: change default sso login logo

b8a4962

feat: add sso valid user cache

af85aff

feat: add validation that user is still an employee

284d7a6

chore: test new validation

e73c0aa

Anty0 requested changes Oct 25, 2024

View reviewed changes

huglx added 12 commits October 26, 2024 14:25

feat: move ssoDomain from UserAccount to separate entity

6c0b685

chore: update tests

fc83174

fix: use enum as ThirdPartyAuthType instead of string

b69c9b6

feat: prevent sso user to login

ffdcbe4

feat: prevent sso user to change password

c77ee5e

feat: add global sso config

370a51e

chore: test global sso config

b9681d3

fix: use frontend url from config, instead of saving it to db

e046416

fix: use frontend url from config, instead of saving it to db

873324d

chore: update tests

a960a6c

chore: update docs property descriptions

2397931

chore: fix ktlint

1cfa8df

Anty0 requested changes Oct 31, 2024

View reviewed changes

Anty0 merged commit 86ae87b into sso Oct 31, 2024
24 of 29 checks passed

Anty0 deleted the ivanmanzhosov/sso branch October 31, 2024 22:32

Anty0 restored the ivanmanzhosov/sso branch October 31, 2024 22:32

Anty0 reviewed Nov 1, 2024

View reviewed changes

ee/backend/app/src/main/kotlin/io/tolgee/ee/service/TenantService.kt Show resolved Hide resolved

Anty0 reviewed Nov 1, 2024

View reviewed changes

ee/backend/app/src/main/kotlin/io/tolgee/ee/service/OAuthService.kt Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: sso implementation #2523

feat: sso implementation #2523

huglx commented Oct 6, 2024

Anty0 left a comment

Anty0 left a comment •

edited

Loading

feat: sso implementation #2523

feat: sso implementation #2523

Conversation

huglx commented Oct 6, 2024

Anty0 left a comment

Choose a reason for hiding this comment

Anty0 left a comment • edited Loading

Choose a reason for hiding this comment

Anty0 left a comment •

edited

Loading