fix: changes from first PR (sso) #2667

huglx · 2024-11-01T17:39:57Z

I'll try to summarize what I've done here:

Functions and fields have been renamed.
Moved the SsoTenant class from the EE repository.
Removed SsoConfig (entity to store UserAccount and domain name); now uses the relationship between SsoTenant and UserAccount.
Added a foreign key for the organization in SsoTenant.
Use of a cacheable user entity to validate SSO users instead of using a cache with an expiration manager.
Kept the global tenant in the database since the link between SsoTenant and UserAccount does not work without it.
Threw an exception when disabling native authentication and attempting to log in.
When saving the thirdAuthType enumeration, @Convert is used instead of @Enumerated.

…organization's FK to ssoTenant

…h the previous values in db

…isabled tenant

…quest

…with expiration manager

backend/api/src/main/kotlin/io/tolgee/security/thirdParty/OAuthUserHandler.kt

backend/data/src/main/kotlin/io/tolgee/model/SsoTenant.kt

backend/data/src/main/kotlin/io/tolgee/model/UserAccount.kt

ee/backend/app/src/main/kotlin/io/tolgee/ee/service/TenantService.kt

Anty0 · 2024-11-04T15:54:23Z

I'll take care of fixing the rest of these. :)

huglx added 14 commits November 1, 2024 12:19

chore: move SsoTenant from ee repo, link user account and SsoTenant, …

4914735

…organization's FK to ssoTenant

chore: rename ssoTenant column

4b30714

chore: rename OAuthService's function

44e7167

fix: use @convert instead of @Enumerated to avoid incompatibility wit…

df24981

…h the previous values in db

fix: use getEnabledByDomain instead of getByDomain to prevent using d…

5c77185

…isabled tenant

fix: throw if native auth is disabled and login endpoint is called

adb316d

chore: code cleaning

a7b2f26

fix: validate thirdPartyAuth type and handle invalid values as bad re…

0d88bda

…quest

fix: use cacheable user entity to validate sso user instead of cache …

26df30a

…with expiration manager

fix: save global tenant in db

1c63119

feat: dont auth user if it's global sso and there is no invite code

4e99ce0

fix: add validation

ba4eccf

fix: ktlint check

ce3bf2b

fix: ktlint check

593f746

huglx requested a review from Anty0 November 1, 2024 17:39

chore: update SsoProviderControllerTest

22bd59b

huglx changed the title ~~fix: changes from first PR~~ fix: changes from first PR (sso) Nov 4, 2024

Anty0 requested changes Nov 4, 2024

View reviewed changes

Anty0 merged commit 5eb67cd into sso Nov 4, 2024
27 of 29 checks passed

Anty0 deleted the ivanmanzhosov/sso branch November 4, 2024 15:54

Provide feedback