Various fixes, zoom support, dependencies for real terminal emulation #20
Conversation
|
@tolmasky ping |
|
Hi I'm just about to jump on a plane but didn't want this to go unresponded to. I'm going to try my best to look at this this week. Thanks! |
|
Great, thanks! I have more changes that make it easier to sync terminal keyboard events with terminal output. That way you can avoid the terminal falling behind your typing and ruining the line wrapping. I've also been experimenting with getting hover events to show up properly during simulated mouse movement. Looking forward to getting your perspective on that as well. |
|
@tolmasky still interested in merging this? I have a separate set of patches based on this that updates to electron v3 |
|
Hi abjouh, sorry for the delay -- I think if we can split these up a bit, it would help me taking it in, since currently whenever I have a little time, I start and never finish reviewing it all. Specifically, it would be nice to split easy fixes like Electron updates, from "UI fixes" like the zoomLevel stuff, to potentially security affecting fixes like adding node-pty (where if you run demokit with that on it could potentially allow arbitrary websites to gain access to your computer). One of the ideas of DemoKit is that you might want to run it in CI for example, and I'd want to at the very least significantly document the dangers of turning on node integration if we have that feature since some people may not know what that allows. |
|
Reduced these to the four simplest ones. Will push other PRs for other features individually. |
These are needed for real xterm.js support
This, together with xterm.js is needed for actual terminal emulation.
Using mutating an element that's already in the DOM is a source of very confusing behavior in newer versions of Electron and Chrome. In some cases it results in two separate instances of the DOM elements loaded within the webview. Instead we use DOM.createElement(...).
This makes it easier to debug operations that appear to hang when they fail to "resolve" before the page unloads. We also set a a "transient" to true in the object passed to rejection. User-level code can check for transient === true and retry accordingly.
Switch from mouse event logic in mouse.mm to Electron's own
sendInputEvent API. This appears to be more reliable and
makes it easier to send additional events that simulate hover
events.
We now send mouseEnter, mouseMove events after completing
a move. If two successive mouse moves are in two different
windows, we now send a mouseLeave event to the previous window.
Also support double-click events by overloading the click
argument to support integer values. To simulate a double-click,
use {click: 2, ...}
No description provided.